-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-minor] Remove the obsolete createBlob
helper function
#9987
Conversation
At this point in time, all supported browsers have native support for `Blob`; please see https://developer.mozilla.org/en-US/docs/Web/API/Blob/Blob#Browser_compatibility. Furthermore, note how the helper function was throwing an error if `Blob` isn't available anyway.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/68bc263d7903ef3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f35dfc519cd4897/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f35dfc519cd4897/output.txt Total script time: 7.31 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/68bc263d7903ef3/output.txt Total script time: 8.08 mins
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://54.67.70.0:8877/a96862e2a184563/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/8b4277cfd9287af/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/8b4277cfd9287af/output.txt Total script time: 30.80 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a96862e2a184563/output.txt Total script time: 36.63 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/da6ffae7ebffa47/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/da6ffae7ebffa47/output.txt Total script time: 7.21 mins Published |
Nice find! |
At this point in time, all supported browsers have native support for
Blob
; please see https://developer.mozilla.org/en-US/docs/Web/API/Blob/Blob#Browser_compatibility.Furthermore, note how the helper function was throwing an error if
Blob
isn't available anyway.