Merge pull request #9987 from Snuffleupagus/rm-createBlob

[api-minor] Remove the obsolete `createBlob` helper function
mozilla · Aug 19, 2018 · 4ea663a · 4ea663a
2 parents 46ae238 + 50a47be
commit 4ea663a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 15 deletions.
diff --git a/src/pdf.js b/src/pdf.js
@@ -101,7 +101,6 @@ exports.createValidAbsoluteUrl = pdfjsSharedUtil.createValidAbsoluteUrl;
 exports.createObjectURL = pdfjsSharedUtil.createObjectURL;
 exports.removeNullCharacters = pdfjsSharedUtil.removeNullCharacters;
 exports.shadow = pdfjsSharedUtil.shadow;
-exports.createBlob = pdfjsSharedUtil.createBlob;
 exports.Util = pdfjsSharedUtil.Util;
 exports.ReadableStream = pdfjsSharedUtil.ReadableStream;
 exports.URL = pdfjsSharedUtil.URL;

diff --git a/src/shared/util.js b/src/shared/util.js
@@ -969,21 +969,14 @@ function createPromiseCapability() {
   return capability;
 }
 
-var createBlob = function createBlob(data, contentType) {
-  if (typeof Blob !== 'undefined') {
-    return new Blob([data], { type: contentType, });
-  }
-  throw new Error('The "Blob" constructor is not supported.');
-};
-
 var createObjectURL = (function createObjectURLClosure() {
   // Blob/createObjectURL is not available, falling back to data schema.
   var digits =
     'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=';
 
   return function createObjectURL(data, contentType, forceDataSchema = false) {
     if (!forceDataSchema && URL.createObjectURL) {
-      var blob = createBlob(data, contentType);
+      const blob = new Blob([data], { type: contentType, });
       return URL.createObjectURL(blob);
     }
 
@@ -1033,7 +1026,6 @@ export {
   arraysToBytes,
   assert,
   bytesToString,
-  createBlob,
   createPromiseCapability,
   createObjectURL,
   deprecated,

diff --git a/web/app.js b/web/app.js
@@ -21,10 +21,10 @@ import {
   TextLayerMode
 } from './ui_utils';
 import {
-  build, createBlob, createObjectURL, getDocument, getFilenameFromUrl,
-  GlobalWorkerOptions, InvalidPDFException, LinkTarget, loadScript,
-  MissingPDFException, OPS, PDFWorker, shadow, UnexpectedResponseException,
-  UNSUPPORTED_FEATURES, URL, version
+  build, createObjectURL, getDocument, getFilenameFromUrl, GlobalWorkerOptions,
+  InvalidPDFException, LinkTarget, loadScript, MissingPDFException, OPS,
+  PDFWorker, shadow, UnexpectedResponseException, UNSUPPORTED_FEATURES, URL,
+  version
 } from 'pdfjs-lib';
 import { CursorTool, PDFCursorTools } from './pdf_cursor_tools';
 import { PDFRenderingQueue, RenderingStates } from './pdf_rendering_queue';
@@ -748,7 +748,7 @@ let PDFViewerApplication = {
     }
 
     this.pdfDocument.getData().then(function(data) {
-      let blob = createBlob(data, 'application/pdf');
+      const blob = new Blob([data], { type: 'application/pdf', });
       downloadManager.download(blob, url, filename);
     }).catch(downloadByUrl); // Error occurred, try downloading with the URL.
   },