Clean-up getMainThreadWorkerMessageHandler for non-PRODUCTION mode
#9611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*This is a final piece of clean-up of code that I recently wrote, after which I'm done :-)* When the `getMainThreadWorkerMessageHandler` function was added, in PR 9385, it did so by basically introducing a `web/app.js` dependency in `src/display/api.js` through the `window.pdfjsNonProductionPdfWorker` property[1]. Even though this is limited to non-`PRODUCTION` mode, i.e. `gulp server`, it still seems unfortunate to have that sort of viewer dependency in the API code itself. With the new, much nicer and shorter, names introduced in PR 9565 we can remove this non-`PRODUCTION` hack and just use `window.pdfjsWorker` in both the viewer and the API regardless of the build mode. --- [1] It didn't seem correct to piggy-back on the `window.pdfjsDistBuildPdfWorker` property in non-`PRODUCTION` mode.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0c66e4c073272d8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0c66e4c073272d8/output.txt Total script time: 2.71 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/62c15606492f067/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/760982d25738544/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/62c15606492f067/output.txt Total script time: 18.07 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/760982d25738544/output.txt Total script time: 24.41 mins
|
timvandermeij
approved these changes
Mar 31, 2018
|
Thank you! |
Snuffleupagus
deleted the
getMainThreadWorkerMessageHandler-non-PRODUCTION
branch
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…rMessageHandler-non-PRODUCTION Clean-up `getMainThreadWorkerMessageHandler` for non-PRODUCTION mode
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a final piece of clean-up of code that I recently wrote, after which I'm done :-)
When the
getMainThreadWorkerMessageHandlerfunction was added, in PR #9385, it did so by basically introducing aweb/app.jsdependency insrc/display/api.jsthrough thewindow.pdfjsNonProductionPdfWorkerproperty[1]. Even though this is limited to non-PRODUCTIONmode, i.e.gulp server, it still seems unfortunate to have that sort of viewer dependency in the API code itself.With the new, much nicer and shorter, names introduced in PR #9565 we can remove this non-
PRODUCTIONhack and just usewindow.pdfjsWorkerin both the viewer and the API regardless of the build mode.[1] It didn't seem correct to piggy-back on the
window.pdfjsDistBuildPdfWorkerproperty in non-PRODUCTIONmode.