-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the globals to shorter names. #9565
Conversation
/botio test |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 1 Live output at: http://54.215.176.217:8877/4f3e590d22d18a9/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6d9e540ae6362b0/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/f3b9fe3b0420fe2/output.txt Total script time: 2.89 mins
Image differences available at: http://54.215.176.217:8877/f3b9fe3b0420fe2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/6d9e540ae6362b0/output.txt Total script time: 18.67 mins
Image differences available at: http://54.67.70.0:8877/6d9e540ae6362b0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/4f3e590d22d18a9/output.txt Total script time: 24.11 mins
|
var workerOutput = gulp.src('./src/pdf.worker.js') | ||
.pipe(webpack2Stream(workerFileConfig)) | ||
.pipe(replaceWebpackRequire()) | ||
.pipe(replaceJSRootName(workerAMDName)); | ||
.pipe(replaceJSRootName(workerAMDName, 'pdfjsWorker')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the code uses pdfjsLibWorker
, so this line (or the rest of the patch) needs to be fixed :-)
pdfjsDistBuildPdf=pdfjsLib pdfjsDistWebPdfViewer=pdfjsViewer pdfjsDistBuildPdfWorker=pdfjsWorker
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b76ab83f0c86b8c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/b8e984568138c6b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b76ab83f0c86b8c/output.txt Total script time: 18.88 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/b8e984568138c6b/output.txt Total script time: 24.21 mins
|
Rename the globals to shorter names.
pdfjsDistBuildPdf=pdfjsLib
pdfjsDistWebPdfViewer=pdfjsViewer
pdfjsDistBuildPdfWorker=pdfjsWorker
See #9545