Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct stream position when reading maxSizeOfInstructions from the maxp table (issue 9458) #9460

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 7, 2018

Please refer to the maxp table specification, found at https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6maxp.html.

Fixes #9458.

Edit: Note that the test "failures" in Chrome on the Windows bot are simply the inverse of #8955 (comment).

…from the `maxp` table (issue 9458)

Please refer to the `maxp` table specification, found at https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6maxp.html.

Fixes 9458.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Feb 7, 2018

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/faf12d1b1281ad9/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 7, 2018

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/1c2faae30b3e7ea/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 7, 2018

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/1c2faae30b3e7ea/output.txt

Total script time: 24.13 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/1c2faae30b3e7ea/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Feb 7, 2018

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/faf12d1b1281ad9/output.txt

Total script time: 39.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2018

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/834aef5aea45620/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2018

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/dfbb5421a26d4c2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2018

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/dfbb5421a26d4c2/output.txt

Total script time: 21.92 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2018

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/834aef5aea45620/output.txt

Total script time: 36.53 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus merged commit 15c932c into mozilla:master Feb 8, 2018
@Snuffleupagus Snuffleupagus deleted the issue-9458 branch February 8, 2018 08:10
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Use the correct stream position when reading `maxSizeOfInstructions` from the `maxp` table (issue 9458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants