Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite maxSizeOfInstructions in maxp with computed value. #8955

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Overwrite maxSizeOfInstructions in maxp with computed value. #8955

merged 1 commit into from
Sep 26, 2017

Conversation

brendandahl
Copy link
Contributor

In issue #7507 the value is less than the actuall max size
of the glyph instructions causing OTS to fail the font.

Fixes #7507

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9f8cee9102a3c68/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/6175a9613ebca42/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/9f8cee9102a3c68/output.txt

Total script time: 16.53 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/9f8cee9102a3c68/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/6175a9613ebca42/output.txt

Total script time: 22.72 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/6175a9613ebca42/reftest-analyzer.html#web=eq.log

@brendandahl
Overwrite maxSizeOfInstructions in maxp with computed value.
18e2321 
In issue mozilla#7507 the value is less than the actuall max size
of the glyph instructions causing OTS to fail the font.
@brendandahl
Copy link
Contributor Author

Forgot the pdf file :(
/botio test

@mozilla mozilla deleted a comment from pdfjsbot Sep 26, 2017
@mozilla mozilla deleted a comment from pdfjsbot Sep 26, 2017
@mozilla mozilla deleted a comment from pdfjsbot Sep 26, 2017
@mozilla mozilla deleted a comment from pdfjsbot Sep 26, 2017
@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/fa1e01b5ec339f8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/3cddcdecd137765/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/3cddcdecd137765/output.txt

Total script time: 16.53 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/fa1e01b5ec339f8/output.txt

Total script time: 22.73 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/fa1e01b5ec339f8/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Sep 26, 2017
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for fixing this!

@Snuffleupagus
Copy link
Collaborator

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/6f82267ffda3977/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/285d512dfeef041/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/6f82267ffda3977/output.txt

Total script time: 15.44 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/285d512dfeef041/output.txt

Total script time: 20.92 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus merged commit b837187 into mozilla:master Sep 26, 2017
@SamyCookie SamyCookie mentioned this pull request Sep 26, 2017
Closed
This was referenced Feb 7, 2018
Closed
Merged
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
@Snuffleupagus
Merge pull request mozilla#8955 from brendandahl/issue7507
bf254ba 
Overwrite maxSizeOfInstructions in maxp with computed value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
font-conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendandahl @pdfjsbot @Snuffleupagus