Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Make stamp annotations editable (bug 1921291) #18834

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[Editor] Make stamp annotations editable (bug 1921291) #18834

merged 1 commit into from
Oct 4, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e7f10fe2e8e301a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d767c20151edf8c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d767c20151edf8c/output.txt

Total script time: 9.69 mins

  • Integration Tests: Passed

@calixteman
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bf341dd919fff72/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/bf341dd919fff72/output.txt

Total script time: 1.02 mins

Published

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e7f10fe2e8e301a/output.txt

Total script time: 22.13 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the changes here, please also run the full test-suite when the comments have been addressed.

web/struct_tree_layer_builder.js Outdated Show resolved Hide resolved
src/display/editor/stamp.js Outdated Show resolved Hide resolved
src/display/editor/stamp.js Outdated Show resolved Hide resolved
@Snuffleupagus

This comment was marked as resolved.

Sign in to view
Snuffleupagus
Snuffleupagus approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments addressed and the full test-suite passing; thank you.

Given that the structTree is now being used in the editor-layer as well, we need to change this code

pdf.js/web/pdf_page_view.js

Lines 1101 to 1106 in ebbd019

if (this.textLayer || this.annotationLayer) {
this.structTreeLayer ||= new StructTreeLayerBuilder(
pdfPage,
viewport.rawDims
);
}

into just (i.e. initialize it unconditionally)

        this.structTreeLayer ||= new StructTreeLayerBuilder(
          pdfPage,
          viewport.rawDims
        );

web/pdf_viewer.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/967df609ff6631f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/b5709aa053e413b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/967df609ff6631f/output.txt

Total script time: 31.58 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 15
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/967df609ff6631f/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b5709aa053e413b/output.txt

Total script time: 47.14 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/b5709aa053e413b/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit e9c81a6 into mozilla:master Oct 4, 2024
8 checks passed
@calixteman calixteman deleted the edit_stamp1 branch October 4, 2024 05:53
@marco-c marco-c mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus