Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support editing already existing ink-/stamp-annotations #16883

Closed
DDHSchmidt opened this issue Aug 28, 2023 · 3 comments · Fixed by #19151
Closed

Support editing already existing ink-/stamp-annotations #16883

DDHSchmidt opened this issue Aug 28, 2023 · 3 comments · Fixed by #19151
Assignees

Comments

@DDHSchmidt
Copy link

Disclaimer: This is more or less a clone of issue #15403 with an expanded scope

Attach (recommended) or Link to PDF file here:
dummy.pdf

Configuration:

  • Web browser and its version: Firefox 116.0.3
  • Operating system and its version: Windows 10 (22H2)
  • PDF.js version: 3.8.110
  • Is a browser extension: No

Steps to reproduce the problem:

  1. Add an ink or stamp annotation
  2. Save the pdf under a different name
  3. Reload the saved pdf
  4. The added ink-/stamp-annotations are "burnt in" and can't be edited anymore

What is the expected behavior? (add screenshot)
I would have expected to be able to edit/remove the added annotations.

What went wrong? (add screenshot)
The annotations are "burnt in" after saving. Subsequent reloads of the pdf won't let me edit or remove them

@atrinker
Copy link

Are there any plans to move on this issue in an upcoming release?

@marco-c
Copy link
Contributor

marco-c commented Jun 10, 2024

Yes, we are planning to work on this soon. However, if you're up for it, we'd happily accept contributions to make it happen faster.

@marco-c
Copy link
Contributor

marco-c commented Nov 1, 2024

#18834 did this for stamp annotations.
#18972 is the first step to do this for ink annotations too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants