Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Fix the rect used to click in some freetext integration tests #17802

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[Editor] Fix the rect used to click in some freetext integration tests #17802

merged 1 commit into from
Mar 19, 2024

Conversation

calixteman
Copy link
Contributor

And avoid to uselessly set the pointer listeners in the annotation editor layer.

@calixteman
[Editor] Fix the rect used to click in some freetext integration tests
5437199 
And avoid to uselessly set the pointer listeners in the annotation editor layer.
@calixteman
Copy link
Contributor Author

It helps to fix the test failures in #17790.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/566c03881c6f765/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6bd60765d49621f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/566c03881c6f765/output.txt

Total script time: 0.92 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6bd60765d49621f/output.txt

Total script time: 4.67 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/57c818ffa768829/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8282a8592e626a8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/57c818ffa768829/output.txt

Total script time: 7.40 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/8282a8592e626a8/output.txt

Total script time: 17.84 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit a142c8c into mozilla:master Mar 19, 2024
9 checks passed
@calixteman calixteman deleted the fix_tests branch March 19, 2024 09:50
calixteman added a commit to calixteman/pdf.js that referenced this pull request Mar 19, 2024
@calixteman
Don't hide the editor layer when rotating (follow-up of mozilla#17802)
ab0b0d0 
Before the patch in mozilla#17802, the layer was made visible when calling updateMode
after the rotation angle was set.
calixteman added a commit to calixteman/pdf.js that referenced this pull request Mar 19, 2024
@calixteman
Don't hide the editor layer when rotating (follow-up of mozilla#17802)
a3873e4 
Before the patch in mozilla#17802, the layer was made visible when calling updateMode
after the rotation angle was set.
@calixteman calixteman mentioned this pull request Mar 19, 2024
Merged
calixteman added a commit that referenced this pull request Mar 19, 2024
@calixteman
Merge pull request #17809 from calixteman/rotate_editor_layer
3718d0a 
Don't hide the editor layer when rotating (follow-up of #17802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus