-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Make the text layer focusable before the editors (bug 1881746) #17790
Conversation
059f93e
to
a96bb40
Compare
481abce
to
6ae95cd
Compare
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/ac036192a49fb4e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/719f25935134e4b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/719f25935134e4b/output.txt Total script time: 7.10 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ac036192a49fb4e/output.txt Total script time: 18.74 mins
|
a5d45dd
to
f891803
Compare
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/63bc28f51dc71d3/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3650e57e7fe1051/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3650e57e7fe1051/output.txt Total script time: 7.22 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/63bc28f51dc71d3/output.txt Total script time: 22.78 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with one more comment; thanks!
5873087
to
b40cd44
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9c934614ba73409/output.txt |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e82c93a1ac49535/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4e53b23843fe5d0/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not removing the following now dead code:
pdf.js/web/annotation_editor_layer_builder.js
Line 129 in e30fd28
this.pageDiv = null; |
Sorry, my bad, I thought it was in the ctor.... let me fix that. |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e82c93a1ac49535/output.txt Total script time: 6.98 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4e53b23843fe5d0/output.txt Total script time: 19.60 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3b71a7ae15a8d0f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2c66d252456ba0a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3b71a7ae15a8d0f/output.txt Total script time: 7.00 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2c66d252456ba0a/output.txt Total script time: 20.52 mins
|
Keep the different layers in a constant order to avoid the use of a z-index and a tab-index.
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6c1aa288d1e0ae3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/98c7fa6a1f1463e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6c1aa288d1e0ae3/output.txt Total script time: 6.81 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/98c7fa6a1f1463e/output.txt Total script time: 18.97 mins
|
The goal of this patch is to fix the test: https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs/test/browser_pdfjs_zoom.js It's a regression due to mozilla#17790.
The goal of this patch is to fix the test: https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs/test/browser_pdfjs_zoom.js It's a regression due to mozilla#17790.
The goal of this patch is to fix the test: https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs/test/browser_pdfjs_zoom.js It's a regression due to mozilla#17790.
The goal of this patch is to fix the test: https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs/test/browser_pdfjs_zoom.js It's a regression due to mozilla#17790.
The goal of this patch is to fix the test: https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs/test/browser_pdfjs_zoom.js It's a regression due to mozilla#17790.
Keep the different layers in a constant order to avoid the use of a z-index and a tab-index.