Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GrabToPan] Use Element.matches() rather than prefixed ...matchesSelector versions #13144

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

At this point in time all of the browsers that PDF.js support now implements, with some margin based on the version numbers, Element.matches() according to the following compatibility information:

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/242ee1e13d18836/output.txt

@Snuffleupagus Snuffleupagus changed the title [GrabToPan] Use Element.matches() rather than prefixed "...matchesSelector` versions [GrabToPan] Use Element.matches() rather than prefixed ...matchesSelector versions Mar 25, 2021
@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/242ee1e13d18836/output.txt

Total script time: 4.64 mins

Published

@timvandermeij
Copy link
Contributor

Looks good with a rebase.

…elector` versions

At this point in time all of the browsers that PDF.js support now implements, with some margin based on the version numbers, `Element.matches()` according to the following compatibility information:
 - https://developer.mozilla.org/en-US/docs/Web/API/Element/matches#browser_compatibility
 - https://caniuse.com/matchesselector
@timvandermeij timvandermeij merged commit 5bb1634 into mozilla:master Mar 26, 2021
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the GrabToPan-matches branch March 26, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants