[GrabToPan] Prefer the standard, rather than a prefixed, matchesSelector value
#13142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that `matchesSelector` isn't necessary until `GrabToPan` is both enabled *and* used, it doesn't seem necessary to run this code unconditionally.
…ctor` value Given how these checks are currently implemented, they will *always* prefer the prefixed versions over the standard one which does seem quite unfortunate. This looks especially bad in MOZCENTRAL-builds, since Firefox nowadays support a number of `webkit`-prefixes/methods to improve web-compatiblity, where we thus end up using `webkitMatchesSelector`. To address this I'm thus proposing that we simply *reverse* the order in which we check for the `matchesSelector` value, which according to the following compatibility information ought to work fine in general: https://developer.mozilla.org/en-US/docs/Web/API/Element/matches#browser_compatibility
Snuffleupagus
commented
Mar 25, 2021
| /** | ||
| * @private | ||
| */ | ||
| get _matchesSelector() { |
There was a problem hiding this comment.
We could perhaps even add a fast-path for MOZCENTRAL here, e.g. as outlined below, however given that this code no longer runs unconditionally that's probably not necessary.
if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
return shadow(this, "matchesSelector", "matches");
}
Actually, looking at that table a bit closer now, I'm starting to wonder if we could simply remove the |
|
Closing in favour of PR #13144. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given how these checks are currently implemented, they will always prefer the prefixed versions over the standard one which does seem quite unfortunate.
This looks especially bad in MOZCENTRAL-builds, since Firefox nowadays support a number of
webkit-prefixes/methods to improve web-compatiblity, where we thus end up usingwebkitMatchesSelector.To address this I'm thus proposing that we simply reverse the order in which we check for the
matchesSelectorvalue, which according to the following compatibility information ought to work fine in general:https://developer.mozilla.org/en-US/docs/Web/API/Element/matches#browser_compatibility