Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An option is missing for last versions of worker-loader to use pdf.js with webpack #12825

Merged
merged 1 commit into from
Jan 7, 2021
Merged

An option is missing for last versions of worker-loader to use pdf.js with webpack #12825

merged 1 commit into from
Jan 7, 2021

Conversation

fdaveine
Copy link
Contributor

@fdaveine fdaveine commented Jan 7, 2021

Fix #12813

Snuffleupagus
Snuffleupagus requested changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are small enough, and sufficiently connected, that a single commit will suffice here; please see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits

@fdaveine
Copy link
Contributor Author

fdaveine commented Jan 7, 2021

@Snuffleupagus fixed

Snuffleupagus
Snuffleupagus requested changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message contains "work-loader" (more than once), which looks like a typo; please fix that as well.

@fdaveine
Copy link
Contributor Author

fdaveine commented Jan 7, 2021

@Snuffleupagus fixed too 👍

@Snuffleupagus
Copy link
Collaborator

fixed too +1

Not quite, since you still have the incorrect package name in your commit message :-)

@fdaveine
1. Add filename option in worker-loader package require. Without …
35b15cc 
…this option, since version 3.0.0, it tell webpack to generate a worker file named `pdf.worker.worker.js` instead of the expected `pdf.worker.js`.

2. Update README of webpack example to mention that a version 3.0.0 or higher of the `worker-loader` package is now required.
@fdaveine
Copy link
Contributor Author

fdaveine commented Jan 7, 2021

Not quite, since you still have the incorrect package name in your commit message :-)

Sorry I misread your previous comment, should be fixed now...

@timvandermeij timvandermeij merged commit d8e42f7 into mozilla:master Jan 7, 2021
@timvandermeij
Copy link
Contributor

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus requested changes

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webpack instructions can't work with last worker-loader versions
3 participants
@fdaveine @Snuffleupagus @timvandermeij