Skip to content

Commit

Permalink
Merge pull request #12825 from fdaveine/worker-loader-missing-option-…
Browse files Browse the repository at this point in the history
…for-webpack-usage

An option is missing for last versions of worker-loader to use pdf.js with webpack
  • Loading branch information
timvandermeij authored Jan 7, 2021
2 parents ed3758f + 35b15cc commit d8e42f7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion examples/webpack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ the worker code, and the `workerSrc` path shall be set to the latter file.
If you are getting the `Setting up fake worker` warning, make sure you are
importing `pdfjs-dist/webpack` which is the zero-configuration method for
Webpack users. You will need to install
[worker-loader](https://github.com/webpack-contrib/worker-loader) as a
[worker-loader](https://github.com/webpack-contrib/worker-loader) (version 3.0.0 or higher is required), as a
dependency in your project in order to use `pdfjs-dist/webpack` (configuring
`worker-loader` is not necessary; just installing it is sufficient).

Expand Down
2 changes: 1 addition & 1 deletion external/dist/webpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"use strict";

var pdfjs = require("./build/pdf.js");
var PdfjsWorker = require("worker-loader?esModule=false!./build/pdf.worker.js");
var PdfjsWorker = require("worker-loader?esModule=false&filename=[name].js!./build/pdf.worker.js");

if (typeof window !== "undefined" && "Worker" in window) {
pdfjs.GlobalWorkerOptions.workerPort = new PdfjsWorker();
Expand Down

0 comments on commit d8e42f7

Please sign in to comment.