Tweak the pdf.scripting.js bundling, to improve overall consistency
#12529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the new `pdf.scripting.js` bundling more in-line with the pre-existing handling for the `pdf.js`/`pdf.worker.js` files: - Add a new `src/pdf.scripting.js` file as the entry-point for the build scripts. - Add the version/build numbers at the top of the *built* `pdf.scripting.js` files, since all other built files include that information given that it's often helpful to be able to easily determine the *exact* version. - Tweak the `createScriptingBundle` in the gulp-file, since it looks like a little bit too much copy-and-paste in the variable names.
timvandermeij
approved these changes
Oct 25, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the new
pdf.scripting.jsbundling more in-line with the pre-existing handling for thepdf.js/pdf.worker.jsfiles:Add a new
src/pdf.scripting.jsfile as the entry-point for the build scripts.Add the version/build numbers at the top of the built
pdf.scripting.jsfiles, since all other built files include that information given that it's often helpful to be able to easily determine the exact version.Tweak the
createScriptingBundlein the gulp-file, since it looks like a little bit too much copy-and-paste in the variable names.