Skip to content

Commit

Permalink
Merge pull request #12529 from Snuffleupagus/scripting-build-tweaks
Browse files Browse the repository at this point in the history
Tweak the `pdf.scripting.js` bundling, to improve overall consistency
  • Loading branch information
timvandermeij authored Oct 25, 2020
2 parents 2251677 + 61ffa9c commit b2a4dac
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 8 deletions.
16 changes: 8 additions & 8 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -317,20 +317,20 @@ function createMainBundle(defines) {
}

function createScriptingBundle(defines) {
var mainAMDName = "pdfjs-dist/build/pdf.scripting";
var mainOutputName = "pdf.scripting.js";
var scriptingAMDName = "pdfjs-dist/build/pdf.scripting";
var scriptingOutputName = "pdf.scripting.js";

var mainFileConfig = createWebpackConfig(defines, {
filename: mainOutputName,
library: mainAMDName,
var scriptingFileConfig = createWebpackConfig(defines, {
filename: scriptingOutputName,
library: scriptingAMDName,
libraryTarget: "umd",
umdNamedDefine: true,
});
return gulp
.src("./src/scripting_api/initialization.js")
.pipe(webpack2Stream(mainFileConfig))
.src("./src/pdf.scripting.js")
.pipe(webpack2Stream(scriptingFileConfig))
.pipe(replaceWebpackRequire())
.pipe(replaceJSRootName(mainAMDName, "pdfjsScripting"));
.pipe(replaceJSRootName(scriptingAMDName, "pdfjsScripting"));
}

function createWorkerBundle(defines) {
Expand Down
25 changes: 25 additions & 0 deletions src/pdf.scripting.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/* Copyright 2020 Mozilla Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import { initSandbox } from "./scripting_api/initialization.js";

/* eslint-disable-next-line no-unused-vars */
const pdfjsVersion =
typeof PDFJSDev !== "undefined" ? PDFJSDev.eval("BUNDLE_VERSION") : void 0;
/* eslint-disable-next-line no-unused-vars */
const pdfjsBuild =
typeof PDFJSDev !== "undefined" ? PDFJSDev.eval("BUNDLE_BUILD") : void 0;

export { initSandbox };

0 comments on commit b2a4dac

Please sign in to comment.