Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the heuristics used when dealing with rectangles, i.e. re operators, with zero width/height (issue 12010) #12044

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #12010

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/67e1f2e594322e9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/67e1f2e594322e9/output.txt

Total script time: 29.57 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/67e1f2e594322e9/reftest-analyzer.html#web=eq.log

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the comment addressed and a rebase.

src/display/canvas.js Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

Note to self: makeref after this will also apply to the already merged PRs while the Linux bot was down.

…erators, with zero width/height (issue 12010)
@timvandermeij
Copy link
Contributor

/botio-windows preview

@pdfjsbot
Copy link

pdfjsbot commented Jul 1, 2020

From: Bot.io (Windows)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/13de37e2a06ec1c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 1, 2020

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/13de37e2a06ec1c/output.txt

Total script time: 5.11 mins

Published

@timvandermeij timvandermeij merged commit ec635b8 into mozilla:master Jul 1, 2020
@timvandermeij
Copy link
Contributor

/botio-windows makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 1, 2020

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://54.215.176.217:8877/f5bfd31cce3524f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 1, 2020

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/f5bfd31cce3524f/output.txt

Total script time: 15.50 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-12010 branch July 2, 2020 01:25
@Snuffleupagus Snuffleupagus restored the issue-12010 branch July 2, 2020 02:45
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 2, 2020

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/28b1ce0740ed5ab/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 2, 2020

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/8cfe10b93c9bee6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 2, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/28b1ce0740ed5ab/output.txt

Total script time: 24.59 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 2, 2020

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/8cfe10b93c9bee6/output.txt

Total script time: 29.33 mins

  • Lint: Passed
  • Make references: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 2, 2020

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/4faa6fb5ec962bd/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 2, 2020

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/4faa6fb5ec962bd/output.txt

Total script time: 29.07 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-12010 branch July 2, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corner rendered incorrectly in figure
3 participants