Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corner rendered incorrectly in figure #12010

Closed
7Z0t99 opened this issue Jun 18, 2020 · 3 comments · Fixed by #12044
Closed

Corner rendered incorrectly in figure #12010

7Z0t99 opened this issue Jun 18, 2020 · 3 comments · Fixed by #12044
Labels

Comments

@7Z0t99
Copy link

7Z0t99 commented Jun 18, 2020

Link to PDF file: http://mirrors.ctan.org/graphics/pgf/contrib/circuitikz/doc/circuitikzmanual.pdf (version 1.1.2)

Configuration:

  • Web browser and its version: Firefox 77.0.1
  • Operating system and its version: Windows 10 1909
  • PDF.js version: 2.5.95 (included in Firefox)

Consider the bottom left corner in the figure at the bottom of page 148.

What is the expected behavior?
correct

What went wrong?
wrong

@THausherr
Copy link
Contributor

reduced file:
PDFJS-12010-p153-reduced.pdf

This is somehow related to a rectangle having a zero width.

@calixteman
Copy link
Contributor

It's because of:
https://github.com/mozilla/pdf.js/blob/master/src/display/canvas.js#L1189
The pdf docs:
https://www.adobe.com/content/dam/acom/en/devnet/pdf/PDF32000_2008.pdf#page=141
don't mention that neither width nor height for a rectangle has a minimal value.
The rendering in evince is correct and the code in poopler doesn't use a minimal width:
https://gitlab.freedesktop.org/poppler/poppler/-/blob/master/poppler/Gfx.cc#L1724
Unfortunately, I'm not able to get the pdf in #4260 (comment) so I can't check what's wrong exactly with it.
Anyway I think that removing these "default" values will fix the issue.
@timvandermeij, @brendandahl wdyt ?

@brendandahl
Copy link
Contributor

@Snuffleupagus might also still have that PDF?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants