Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad typing of linkService and l10n in PDFViewerOptions #16360

Closed
SebCorbin opened this issue Apr 27, 2023 · 0 comments · Fixed by #16361
Closed

Bad typing of linkService and l10n in PDFViewerOptions #16360

SebCorbin opened this issue Apr 27, 2023 · 0 comments · Fixed by #16361
Assignees
@timvandermeij
Labels
other

Comments

@SebCorbin
Copy link
Contributor

PDF.js version: 3.5.141

These two properties should be marked as not mandatory as they are initialized if not present
@SebCorbin SebCorbin changed the title Bad typing of linkService and l10n in PDFViewerOptions Bad typing of linkService and l10n in PDFViewerOptions Apr 27, 2023
@timvandermeij timvandermeij self-assigned this Apr 27, 2023
@timvandermeij timvandermeij mentioned this issue Apr 27, 2023
Merged
SebCorbin added a commit to SebCorbin/pdf.js that referenced this issue Apr 27, 2023
@SebCorbin
Update type documentations for mozilla#16307, mozilla#16359 and mozil…
7d41943 
…la#16360
@SebCorbin SebCorbin mentioned this issue Apr 27, 2023
Merged
SebCorbin added a commit to SebCorbin/pdf.js that referenced this issue Apr 27, 2023
@SebCorbin
Update type documentations for mozilla#16307, mozilla#16359 and mozil…
a7cf28b 
…la#16360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timvandermeij timvandermeij

Labels
other
Projects
None yet
Milestone
No milestone
2 participants
@SebCorbin @timvandermeij