Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad typing for argument rotation of PDFPageView.update #16359

Closed
SebCorbin opened this issue Apr 27, 2023 · 2 comments · Fixed by #16362
Closed

Bad typing for argument rotation of PDFPageView.update #16359

SebCorbin opened this issue Apr 27, 2023 · 2 comments · Fixed by #16362
Labels
other

Comments

@SebCorbin
Copy link
Contributor

PDF.js version: 3.5.141

The type of rotation property in argument of PDFPageView.update is marked as null | undefined but it should be number | undefined
@Snuffleupagus
Copy link
Collaborator

Basically, #16307 (comment) applies here as well.

SebCorbin added a commit to SebCorbin/pdf.js that referenced this issue Apr 27, 2023
@SebCorbin
Update type documentations for mozilla#16307, mozilla#16359 and mozil…
7d41943 
…la#16360
@SebCorbin SebCorbin mentioned this issue Apr 27, 2023
Merged
@SebCorbin
Copy link
Contributor Author

SebCorbin commented Apr 27, 2023 •
edited
Loading

@Snuffleupagus great, I contributed some JSdoc changes for the linked issues.

As a side note, I successfully wrote a viewer (with annotation editing) in Vue using only types and source code as documentation, I must be say thanks to all maintainers!

SebCorbin added a commit to SebCorbin/pdf.js that referenced this issue Apr 27, 2023
@SebCorbin
Update type documentations for mozilla#16307, mozilla#16359 and mozil…
a7cf28b 
…la#16360
SebCorbin added a commit to SebCorbin/pdf.js that referenced this issue Apr 28, 2023
@SebCorbin
Update type documentations for mozilla#16307 and mozilla#16359
d18b9ee
@Snuffleupagus Snuffleupagus linked a pull request Apr 28, 2023 that will close this issue
Update type documentations for #16307, #16359 #16362
Merged
Snuffleupagus added a commit that referenced this issue Apr 28, 2023
@Snuffleupagus
Merge pull request #16362 from SebCorbin/update-types
f28d915 
Update type documentations for #16307, #16359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
other
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update type documentations for #16307, #16359 SebCorbin/pdf.js
3 participants
@SebCorbin @timvandermeij @Snuffleupagus