Bug 1875085 - [marionette] Fallback to type hint "tab" in "WebDriver:…

…NewWindow` on Android when "window" is specified. r=webdriver-reviewers,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D199130
mozilla · Jan 29, 2024 · d60ce00 · d60ce00
1 parent a5249be
commit d60ce00
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/remote/marionette/driver.sys.mjs b/remote/marionette/driver.sys.mjs
@@ -2244,7 +2244,13 @@ GeckoDriver.prototype.newWindow = async function (cmd) {
   }
 
   // If an invalid or no type has been specified default to a tab.
-  if (typeof type == "undefined" || !["tab", "window"].includes(type)) {
+  // On Android always use a new tab instead because the application has a
+  // single window only.
+  if (
+    typeof type == "undefined" ||
+    !["tab", "window"].includes(type) ||
+    lazy.AppInfo.isAndroid
+  ) {
     type = "tab";
   }
 

diff --git a/testing/web-platform/meta/webdriver/tests/classic/new_window/new_window.py.ini b/testing/web-platform/meta/webdriver/tests/classic/new_window/new_window.py.ini