Bug 1874801 - Check that HTTPS-Only is disabled when checking if HTTP…

…S-First is enabled in nsHTTPSOnlyUtils r=freddyb Differential Revision: https://phabricator.services.mozilla.com/D198780
mozilla · Jan 29, 2024 · a5249be · a5249be
1 parent e935285
commit a5249be
Show file tree

Hide file tree

Showing 5 changed files with 96 additions and 2 deletions.
diff --git a/dom/security/nsHTTPSOnlyUtils.cpp b/dom/security/nsHTTPSOnlyUtils.cpp
@@ -42,6 +42,11 @@ bool nsHTTPSOnlyUtils::IsHttpsOnlyModeEnabled(bool aFromPrivateWindow) {
 
 /* static */
 bool nsHTTPSOnlyUtils::IsHttpsFirstModeEnabled(bool aFromPrivateWindow) {
+  // HTTPS-Only takes priority over HTTPS-First
+  if (IsHttpsOnlyModeEnabled(aFromPrivateWindow)) {
+    return false;
+  }
+
   // if the general pref is set to true, then we always return
   if (mozilla::StaticPrefs::dom_security_https_first()) {
     return true;
@@ -122,8 +127,7 @@ void nsHTTPSOnlyUtils::PotentiallyFireHttpRequestToShortenTimout(
   // early if attempting to send a background request to a non standard port.
   if ((IsHttpsFirstModeEnabled(isPrivateWin) ||
        (loadInfo->GetWasSchemelessInput() &&
-        mozilla::StaticPrefs::dom_security_https_first_schemeless())) &&
-      !IsHttpsOnlyModeEnabled(isPrivateWin)) {
+        mozilla::StaticPrefs::dom_security_https_first_schemeless()))) {
     int32_t port = 0;
     nsresult rv = channelURI->GetPort(&port);
     int defaultPortforScheme = NS_GetDefaultPort("http");

diff --git a/dom/security/test/https-only/browser.toml b/dom/security/test/https-only/browser.toml
@@ -4,6 +4,12 @@ prefs = ["dom.security.https_first=false"]
 ["browser_background_redirect.js"]
 support-files = ["file_background_redirect.sjs"]
 
+["browser_bug1874801.js"]
+support-files = [
+  "file_bug1874801.sjs",
+  "file_bug1874801.html",
+]
+
 ["browser_console_logging.js"]
 support-files = ["file_console_logging.html"]
 

diff --git a/dom/security/test/https-only/browser_bug1874801.js b/dom/security/test/https-only/browser_bug1874801.js
@@ -0,0 +1,56 @@
+/* Any copyright is dedicated to the Public Domain.
+   http://creativecommons.org/publicdomain/zero/1.0/ */
+
+"use strict";
+
+// Specifically test https://bugzilla.mozilla.org/show_bug.cgi?id=1874801
+
+const TAB_URL =
+  "https://example.com/browser/dom/security/test/https-only/file_bug1874801.html";
+
+function assertImageLoaded(tab) {
+  return ContentTask.spawn(tab.linkedBrowser, {}, () => {
+    const img = content.document.getElementsByTagName("img")[0];
+
+    ok(!!img, "Image tag should exist");
+    ok(img.complete && img.naturalWidth > 0, "Image should have loaded ");
+  });
+}
+
+add_task(async function test_bug1874801() {
+  await SpecialPowers.pushPrefEnv({
+    set: [
+      ["security.mixed_content.upgrade_display_content", false],
+      ["dom.security.https_first", true],
+      ["dom.security.https_only_mode", true],
+    ],
+  });
+
+  // Open Tab
+  const tabToClose = await BrowserTestUtils.openNewForegroundTab(
+    gBrowser,
+    TAB_URL,
+    true
+  );
+
+  // Make sure the image was loaded via HTTPS
+  await assertImageLoaded(tabToClose);
+
+  // Close Tab
+  const tabClosePromise =
+    BrowserTestUtils.waitForSessionStoreUpdate(tabToClose);
+  BrowserTestUtils.removeTab(tabToClose);
+  await tabClosePromise;
+
+  // Restore Tab
+  const restoredTabPromise = BrowserTestUtils.waitForNewTab(
+    gBrowser,
+    TAB_URL,
+    true
+  );
+  undoCloseTab();
+  const restoredTab = await restoredTabPromise;
+
+  // Make sure the image was loaded via HTTPS
+  await assertImageLoaded(restoredTab);
+});
diff --git a/dom/security/test/https-only/file_bug1874801.html b/dom/security/test/https-only/file_bug1874801.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+  <meta charset="UTF-8">
+  <meta name="viewport" content="width=device-width, initial-scale=1.0">
+  <title>Bug 1874801</title>
+</head>
+<body>
+  <img src="http://example.com/browser/dom/security/test/https-only/file_bug1874801.sjs">
+</body>
+</html>
diff --git a/dom/security/test/https-only/file_bug1874801.sjs b/dom/security/test/https-only/file_bug1874801.sjs
@@ -0,0 +1,17 @@
+/* Any copyright is dedicated to the Public Domain.
+   http://creativecommons.org/publicdomain/zero/1.0/ */
+
+function handleRequest(request, response) {
+  response.setHeader("Cache-Control", "no-cache", false);
+  if (request.scheme === "https") {
+    response.setStatusLine(request.httpVersion, 200, "OK");
+    response.setHeader("Content-Type", "image/svg+xml");
+    response.write(
+      `<svg version="1.1" width="100" height="40" xmlns="http://www.w3.org/2000/svg"><text x="20" y="20">HTTPS</text></svg>`
+    );
+    return;
+  }
+  if (request.scheme === "http") {
+    response.setStatusLine(request.httpVersion, 400, "Bad Request");
+  }
+}