Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no_severity_nag] Exclude security bugs when nagging triage owner #2536

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[no_severity_nag] Exclude security bugs when nagging triage owner #2536

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60adbd1
Added filter to exclude bugs with an security keyword
benjaminmah Nov 6, 2024
fcb5251
Added group check
benjaminmah Nov 6, 2024
55a1b1f
Moved filter to params
benjaminmah Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bugbot/rules/workflow/no_severity_nag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

from bugbot import utils
from bugbot.bzcleaner import BzCleaner
from bugbot.constants import SECURITY_KEYWORDS
from bugbot.escalation import Escalation
from bugbot.nag_me import Nag
from bugbot.round_robin import RoundRobin
Expand Down Expand Up @@ -73,6 +74,8 @@ def handle_bug(self, bug, data):
# check if the product::component is in the list
utils.check_product_component(self.components_skiplist, bug)
or utils.get_last_no_bot_comment_date(bug) > self.activity_date
or any(keyword in SECURITY_KEYWORDS for keyword in bug["keywords"])
or bug["groups"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do any("security" in group for group in bug["groups"]) so we only exclude security bugs and not bugs that are confidential

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could have this in the query directly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this look? 55a1b1f

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could instead add it as a configuration, and it will be added to the query:

bugbot/configs/rules.json

Line 452 in a8b33be

"sec": false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this, I'm a little confused on what you mean. Do you mean adding a new "sec": false configuration under no_severity_nag and then using that as a condition on whether or not to include the security bugs in the params?

):
return None
return bug
Expand Down