[no_severity_nag] Exclude security bugs when nagging triage owner #2536
Conversation
|
Would it make sense to apply this filter to the other rules that nag the triage owner as well? ( |
Which other rules do it? We could ask @mozfreddyb for each of them. |
Looking through the BugBot Wiki, the following are rules that NAG the triage owner: There are other rules that NEEDINFO the triage owner, however. |
| @@ -73,6 +74,8 @@ def handle_bug(self, bug, data): | |||
| # check if the product::component is in the list | |||
| utils.check_product_component(self.components_skiplist, bug) | |||
| or utils.get_last_no_bot_comment_date(bug) > self.activity_date | |||
| or any(keyword in SECURITY_KEYWORDS for keyword in bug["keywords"]) | |||
| or bug["groups"] | |||
There was a problem hiding this comment.
Let's do any("security" in group for group in bug["groups"]) so we only exclude security bugs and not bugs that are confidential
| or any(keyword in SECURITY_KEYWORDS for keyword in bug["keywords"]) | ||
| or bug["groups"] |
There was a problem hiding this comment.
Maybe we could have this in the query directly
There was a problem hiding this comment.
How does this look? 55a1b1f
There was a problem hiding this comment.
You could instead add it as a configuration, and it will be added to the query:
Line 452 in a8b33be
There was a problem hiding this comment.
Can you elaborate on this, I'm a little confused on what you mean. Do you mean adding a new "sec": false configuration under no_severity_nag and then using that as a condition on whether or not to include the security bugs in the params?
| "f34": "bug_group", | ||
| "o34": "substring", | ||
| "v34": "security", |
Resolves #2505.
Excludes any bugs with a security keyword to avoid nagging the triage owner.
Checklist
to-be-announcedtag added if this is worth announcing