Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set LTO to thin. Fixes #2531. DO NOT LAND [ci full] #2535

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Conversation

thomcc
Copy link
Contributor

@thomcc thomcc commented Jan 28, 2020

I did this because it occurs to me that this might not work for us at all, and the CI we currently have in place would tell us.

That said, this might work, which means we should do manual testing or wait for better CI to land it.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • automation/all_tests.sh runs to completion and produces no failures
    • Note: For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@thomcc
Copy link
Contributor Author

thomcc commented Jan 28, 2020

The failures seem strange... ktlint failing for a rust build config change? sync15 (which is pure kotlin) failing to run? These are... almost certainly unrelated, but hard to explain.

All that said, this appears to work, so we should either manually test or wait for better CI. It would also be nice to have numbers for how much faster (if any -- it should be faster) this is, also the negative side like increased binary size, worse perf, etc.

Copy link
Contributor

@eoger eoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested today with 3 different Android devices (x86, arm, arm64) and iPhone, works great.
I've noticed the CI runs are taking ~18 minutes versus 25-35min before so we should definitely merge this!

@thomcc
Copy link
Contributor Author

thomcc commented Feb 21, 2020

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants