-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider switching the megazords to thinlto #2531
Labels
Comments
To ensure I understand what you mean here, since we have a KR about test coverage for Q1 - do you mean that our current tests run in CI are likely not sufficient to catch the kinds of missing-symbols errors that were seen with rust-lang/rust#50007? |
Right, since it causes a failure to load some (all) subparts of the
megazord, but only on some OSes. I actually expect that our current android
unit tests would catch it if it were obviously broken (e.g. if we deleted
the lto=true line, or if thinlto didnt work for us at all), but given that
its a platform dependent issue, it seems like we should check the platforms
we care about
|
thomcc
pushed a commit
that referenced
this issue
Jan 28, 2020
thomcc
pushed a commit
that referenced
this issue
Feb 21, 2020
Set LTO to thin. Fixes #2531. [ci full]
dp-mason
pushed a commit
to dp-mason/application-services
that referenced
this issue
Feb 29, 2020
Build with SQL Cipher 4.3.0 with NSS backend Build with SQL Cipher 4.3.0
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Surprised there's not an issue on file for this already. It should be a 1 line patch (change
application-services/Cargo.toml
Line 40 in 72bbb67
lto = "thin"
), but requires testing on all supported platforms, to ensure we don't regress things WRT rust-lang/rust#50007 (It might be a good thing to do after we have semi-robust CI for them? Or could test manually).Should speed up android builds a decent amount, among others.
┆Issue is synchronized with this Jira Task
┆Epic: important not urgent
┆Sprint: Backlog
The text was updated successfully, but these errors were encountered: