Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching the megazords to thinlto #2531

Closed
thomcc opened this issue Jan 27, 2020 · 2 comments
Closed

Consider switching the megazords to thinlto #2531

thomcc opened this issue Jan 27, 2020 · 2 comments

Comments

@thomcc
Copy link
Contributor

thomcc commented Jan 27, 2020

Surprised there's not an issue on file for this already. It should be a 1 line patch (change

to lto = "thin"), but requires testing on all supported platforms, to ensure we don't regress things WRT rust-lang/rust#50007 (It might be a good thing to do after we have semi-robust CI for them? Or could test manually).

Should speed up android builds a decent amount, among others.

┆Issue is synchronized with this Jira Task
┆Epic: important not urgent
┆Sprint: Backlog

@rfk
Copy link
Contributor

rfk commented Jan 27, 2020

(It might be a good thing to do after we have semi-robust CI for them? Or could test manually)

To ensure I understand what you mean here, since we have a KR about test coverage for Q1 - do you mean that our current tests run in CI are likely not sufficient to catch the kinds of missing-symbols errors that were seen with rust-lang/rust#50007?

@thomcc
Copy link
Contributor Author

thomcc commented Jan 27, 2020 via email

thomcc pushed a commit that referenced this issue Jan 28, 2020
@thomcc thomcc closed this as completed in 235560d Feb 21, 2020
thomcc pushed a commit that referenced this issue Feb 21, 2020
Set LTO to thin. Fixes #2531. [ci full]
dp-mason pushed a commit to dp-mason/application-services that referenced this issue Feb 29, 2020
Build with SQL Cipher 4.3.0 with NSS backend

Build with SQL Cipher 4.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants