Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use peep instead of pip (bug 1118379) #446

Closed
wants to merge 1 commit into from

Conversation

magopian
Copy link
Contributor

@magopian magopian commented Feb 6, 2015

Fixes bug 1118379

Use https://pypi.python.org/pypi/peep instead of plain pip

@magopian magopian force-pushed the 1118379-use-peep branch 16 times, most recently from a77c5c0 to da3b3a2 Compare February 9, 2015 17:42
@magopian
Copy link
Contributor Author

magopian commented Feb 9, 2015

@andymckay r?

Using the github archives instead of the -e git+... options seems to be working well. Instead of that, to not have to rely on github, we could simply create/use the wheels on pyrepo.

One thing to make sure though: have a recent enough version of django-mozilla-product-details (the one we had didn't have a working setup.py I believe, and thus didn't properly install).

@robhudson
Copy link
Member

I think this should also copy the peep.py file to the repo and verify it, otherwise peep itself is the weakest link in the chain. See the peep README for this suggestion.

@andymckay
Copy link

I was going to suggest install peep off of pyrepo and then you don't need to install the rest of pyrepo. Embedding it works too.

To have reproducible environments and make sure what we install is what we
wanted to install, we're moving to use peep_ instead of pip::

pip install peep

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be pulling off pyrepo with == to specify the version, or embed it.

@magopian
Copy link
Contributor Author

This is currently broken, I believe because of the incompatibility of peep and pip7 (eg erikrose/peep#94)

Also, I'm not sure we really need/want to use peep. It would allow us to not need pyrepo anymore, installing straight from pypi. However, we'd then have other issues (what if a package is badly updated on pypi as it happened for the python-memcached 1.53 wheel which is in fact now a 1.55 package? Or if someone removes an old version or deletes a package from pypi?).

So I believe we need to keep pyrepo, and we thus don't need peep. Thoughts @andymckay @robhudson?

@kmaglione
Copy link
Contributor

I think I'd still rather have peep, even if we stick with pyrepo. We thought we were getting all of our packages from our wheelhouse before, and things still broke, and were very difficult to diagnose. If we can manage to get this working without making our lives too difficult in the future, I think it's worth it.

@andymckay
Copy link

I agree with @kmaglione, peep is worth it.

@magopian
Copy link
Contributor Author

Closing for now: the peep bug is still open.

If this is reopened, it'll also need some more documentation around how to maintain the requirements files (updating, adding a new requirement, adding the appropriate hashes). Might need a lot of rework if #795 makes it to master (it got reverted in fa65808)

@magopian magopian closed this Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants