-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use peep instead of pip (bug 1118379) #446
Conversation
a77c5c0
to
da3b3a2
Compare
@andymckay r? Using the github archives instead of the One thing to make sure though: have a recent enough version of django-mozilla-product-details (the one we had didn't have a working |
da3b3a2
to
d9b9a47
Compare
I think this should also copy the peep.py file to the repo and verify it, otherwise peep itself is the weakest link in the chain. See the peep README for this suggestion. |
I was going to suggest install peep off of pyrepo and then you don't need to install the rest of pyrepo. Embedding it works too. |
To have reproducible environments and make sure what we install is what we | ||
wanted to install, we're moving to use peep_ instead of pip:: | ||
|
||
pip install peep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be pulling off pyrepo with == to specify the version, or embed it.
82787e5
to
cd61c4c
Compare
cd61c4c
to
447f9fb
Compare
This is currently broken, I believe because of the incompatibility of peep and pip7 (eg erikrose/peep#94) Also, I'm not sure we really need/want to use peep. It would allow us to not need pyrepo anymore, installing straight from pypi. However, we'd then have other issues (what if a package is badly updated on pypi as it happened for the python-memcached 1.53 wheel which is in fact now a 1.55 package? Or if someone removes an old version or deletes a package from pypi?). So I believe we need to keep pyrepo, and we thus don't need peep. Thoughts @andymckay @robhudson? |
I think I'd still rather have peep, even if we stick with pyrepo. We thought we were getting all of our packages from our wheelhouse before, and things still broke, and were very difficult to diagnose. If we can manage to get this working without making our lives too difficult in the future, I think it's worth it. |
I agree with @kmaglione, peep is worth it. |
Closing for now: the peep bug is still open. If this is reopened, it'll also need some more documentation around how to maintain the requirements files (updating, adding a new requirement, adding the appropriate hashes). Might need a lot of rework if #795 makes it to master (it got reverted in fa65808) |
Fixes bug 1118379
Use https://pypi.python.org/pypi/peep instead of plain pip