-
Notifications
You must be signed in to change notification settings - Fork 28
support pip 7, where 'use_wheel' doesn't exist #94
Conversation
@@ -104,6 +104,11 @@ def iter(self, ret, *args, **kwargs): | |||
|
|||
DownloadProgressBar = DownloadProgressSpinner = NullProgressBar | |||
|
|||
try: | |||
from pip.index import FormatControl # 7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the comment here to # noqa
to silence the flake8 unused import warning. (And perhaps move the 7.0 comment to the next line).
Ah raced the PR update :-) |
;-) |
Doesn't look like the tests pass under pip 7.0.1. I added 7.0 and 7.0.1 to the tox setup, and this happens:
|
Yes, as @glogiotatidis explained in #97 there were further incompatibilities. He proposed a fix in that PR, however I went with a different implementation in my last commit here. |
Some of my servers are starting to pick up pip 7 via system packaging and this bug is causing more and more headaches to work around. Is there any way I can help move this forward? |
@@ -104,6 +104,13 @@ def iter(self, ret, *args, **kwargs): | |||
|
|||
DownloadProgressBar = DownloadProgressSpinner = NullProgressBar | |||
|
|||
try: | |||
from pip.index import FormatControl # noqa | |||
format_control_arg = 'format_control' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose these should both be CONSTANTS, or neither should.
Belated thanks for this nifty patch, kouk! Peep 2.5 is out, with your fix. |
No description provided.