Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always trigger event and provide userid #14

Merged
merged 3 commits into from
Feb 11, 2016
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Always notify event when user is identified with authenticated_userid()
leplatrem committed Feb 10, 2016
commit 2c4de901030d06bf4629a7fa387fd97fe52fe372
3 changes: 3 additions & 0 deletions pyramid_multiauth/__init__.py
Original file line number Diff line number Diff line change
@@ -119,6 +119,9 @@ def effective_principals(self, request):
userid = policy.authenticated_userid(request)
if userid is None:
continue
request.registry.notify(MultiAuthPolicySelected(policy,
request,
userid))
groups = self._callback(userid, request)
if groups is not None:
break
7 changes: 7 additions & 0 deletions pyramid_multiauth/tests.py
Original file line number Diff line number Diff line change
@@ -202,6 +202,13 @@ def track_policy(event):
self.assertEquals(selected_policy[0].request, request)
self.assertEquals(len(selected_policy), 1)

# Effective principals also triggers an event when groupfinder
# is provided.
policy_with_group = MultiAuthenticationPolicy(policies,
lambda u, r: ['foo'])
policy_with_group.effective_principals(request)
self.assertEquals(len(selected_policy), 2)

def test_stacking_of_unauthenticated_userid(self):
policies = [TestAuthnPolicy2(), TestAuthnPolicy3()]
policy = MultiAuthenticationPolicy(policies)