Always trigger event and provide userid #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
LGTM |
|
Sounds fine to me :-) FWIW, I don't have any production code using this library anymore, I'd be very happy to divest maintainership responsibility to you guys so you don't feel like you need to ping me in PRs. (I'm happy to be pinged of course, just don't want to slow you down if I don't have to) |
| @@ -37,10 +37,11 @@ def track_policy(event): | |||
| print("We selected policy %s" % event.policy) | |||
|
|
|||
| """ | |||
| def __init__(self, policy, request): | |||
| def __init__(self, policy, request, userid): | |||
There was a problem hiding this comment.
Changing this changes the API in an incompatible way. We might want to have this default to None.
There was a problem hiding this comment.
We can indeed (I will), although nobody is supposed to instantiate those events :)
|
Thanks for that Ryan! In this particular case, it was relevant to require your approval, because we weren't 100% confident about the changes :) |
leplatrem
force-pushed
the
provide-userid-event
branch
from
88e4149 to
e95d339
Compare
leplatrem
added a commit
that referenced
this pull request
Feb 11, 2016
Always trigger event and provide userid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the selected policy event is notified, it is very useful to have the authenticated userid at hand.
This PR provides it.
Also, this PR fixes a «bug» about the event not being always triggered.
Indeed, for the permissions Pyramid calls
effective_principals()which also callsauthenticated_userid()of every contained policy. Whereas the event was sent whenauthenticated_userid()was called explicitly, it wasn't sent when onlyeffective_principals()was called.@almet @rfk r?