Update EmergencyShutOffCard #3005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Add role selection to EmergencyShutoffCard component - Added role selection dropdown to allow users to select their role when signing off. - Modified the onSignoff function to accept the selected role. - Integrated role selection into the component's UI.
conceptacherono
requested review from
jcristau,
gbrownmozilla and
gabrielBusta
as code owners
bhearsum
requested changes
Oct 24, 2023
There was a problem hiding this comment.
I'm so sorry for the long delay here - there's been so many PRs that we lost track of this one. The change looks promising, but unfortunately it seems to cause the UI not to load in my browser. There's a number of exceptions in the Console, but the primary one seems to be:
Uncaught ReferenceError: PropTypes is not defined
|
okay,let me look at it
…On Tue, Oct 24, 2023 at 8:30 PM bhearsum ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I'm so sorry for the long delay here - there's been so many PRs that we
lost track of this one. The change looks promising, but unfortunately it
seems to cause the UI not to load in my browser. There's a number of
exceptions in the Console, but the primary one seems to be:
Uncaught ReferenceError: PropTypes is not defined
—
Reply to this email directly, view it on GitHub
<#3005 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV5EJGT6PLXTV25DKWQONGDYA73LTAVCNFSM6AAAAAA52EZ24GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJVGQ4TONBYGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves ' Unable to select role in signoff dialog to enable updates #2986'
feat: Add role selection to EmergencyShutoffCard component