Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to select role in signoff dialog to enable updates #2986

Open
gbrownmozilla opened this issue Sep 18, 2023 · 7 comments
Open

Unable to select role in signoff dialog to enable updates #2986

gbrownmozilla opened this issue Sep 18, 2023 · 7 comments
Assignees

Comments

@gbrownmozilla
Copy link
Contributor

Currently the Thunderbird release channel has updates disabled. To enable them, we need one more signoff, with role 'tb-releng'. However, the signoff dialog does not provide an option to select the role.

@gbrownmozilla
Copy link
Contributor Author

balrog-signoff

@gbrownmozilla
Copy link
Contributor Author

Maybe a regression from #2604 ?

@gbrownmozilla
Copy link
Contributor Author

(@gabrielBusta worked around the production issue by calling the signoff API directly.)

@gbrownmozilla
Copy link
Contributor Author

Should there be a signoffEnableUpdates entry in dialogStates? https://github.com/mozilla-releng/balrog/blob/main/ui/src/views/Rules/ListRules/index.jsx#L1056

@godplayer56
Copy link
Contributor

Hi @gbrownmozilla Is this issue suitable for outreachy applicants? If so, can you please assign this to me 😅

@gbrownmozilla
Copy link
Contributor Author

I'm not sure how difficult this will be, and I haven't figured out how to test it -- I may not be able to help you much with this one. However, you are welcome to have a look!

@AMUZY
Copy link
Contributor

AMUZY commented Nov 15, 2023

I'm just noticing this myself. Don't worry, I'm on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants