Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine flatpak/dependabot conditions #9993

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Oct 28, 2024

Description

A while back in #9915 and #9930 we added some automation to keep the flatpak manifests in sync as dependabot tries to update the rust crates, and for the most part it has been working great! However, we find that after the job runs and commits the flatpak manifest, the job runs again and ends with an error because the new actor that did the commit doesn't have access to the dependabot secrets.

The error itself is harmless, but it means the CI is red and that makes me unhappy. So let's try to refine the workflow conditions a bit more so the job only runs once. To do this, we need to make it conditional on running with the dependabot actor too.

Reference

Introduced by #9915 and #9930

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby force-pushed the flatpak-refine-depdendabot-conditons branch from 22331f5 to 758a1df Compare October 28, 2024 17:34
@oskirby oskirby requested review from strseb and mcleinman October 28, 2024 17:34
@oskirby oskirby marked this pull request as ready for review October 28, 2024 17:40
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@oskirby oskirby merged commit cb083db into main Oct 29, 2024
146 of 160 checks passed
@oskirby oskirby deleted the flatpak-refine-depdendabot-conditons branch October 29, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants