-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to auto-update flatpak crates #9915
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskirby
force-pushed
the
flatpak-crate-autoupdate
branch
2 times, most recently
from
September 27, 2024 00:12
4916841
to
f65c201
Compare
oskirby
force-pushed
the
flatpak-crate-autoupdate
branch
from
September 27, 2024 00:16
f65c201
to
1c957eb
Compare
oskirby
force-pushed
the
flatpak-crate-autoupdate
branch
5 times, most recently
from
September 27, 2024 00:48
054be64
to
3111945
Compare
oskirby
force-pushed
the
flatpak-crate-autoupdate
branch
from
September 27, 2024 01:38
cddd9b9
to
a35fbfa
Compare
oskirby
force-pushed
the
flatpak-crate-autoupdate
branch
from
September 27, 2024 01:47
dde9c2c
to
0d2025d
Compare
oskirby
force-pushed
the
flatpak-crate-autoupdate
branch
from
September 27, 2024 01:53
0d2025d
to
34252d3
Compare
mcleinman
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After my last messing around with the Flatpak manifests, it turns out that it wasn't a good idea to check in a static version of
flatpak-vpn-crates.json
since ourCargo.lock
is updated automatically by Dependabot and the two files will quickly fall out of sync. Let's make another attempt to write some automation to ensure it's updated.The last time I tried this, it got stuck because Github prevents workflows from retriggering themselves (this runs the risk of creating an infinite loop). So we would wind up with a PR that would automatically update the flatpak manifests, but then none of the required checks wound run, leaving the PR in an un-mergeable state. However, there are some recommended workarounds that we can use.
To try and mitigate the risk of an infinite loop, we set up this workflow so that it only runs on dependabot PRs, and only when there are no changes to the
linux/flatpak
directory.Reference
Github issue #9895
My last attempt: #9616
Checklist