Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to auto-update flatpak crates #9915

Merged
merged 8 commits into from
Sep 27, 2024
Merged

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Sep 27, 2024

Description

After my last messing around with the Flatpak manifests, it turns out that it wasn't a good idea to check in a static version of flatpak-vpn-crates.json since our Cargo.lock is updated automatically by Dependabot and the two files will quickly fall out of sync. Let's make another attempt to write some automation to ensure it's updated.

The last time I tried this, it got stuck because Github prevents workflows from retriggering themselves (this runs the risk of creating an infinite loop). So we would wind up with a PR that would automatically update the flatpak manifests, but then none of the required checks wound run, leaving the PR in an un-mergeable state. However, there are some recommended workarounds that we can use.

To try and mitigate the risk of an infinite loop, we set up this workflow so that it only runs on dependabot PRs, and only when there are no changes to the linux/flatpak directory.

Reference

Github issue #9895
My last attempt: #9616

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby force-pushed the flatpak-crate-autoupdate branch 2 times, most recently from 4916841 to f65c201 Compare September 27, 2024 00:12
@oskirby oskirby force-pushed the flatpak-crate-autoupdate branch from f65c201 to 1c957eb Compare September 27, 2024 00:16
@oskirby oskirby force-pushed the flatpak-crate-autoupdate branch 5 times, most recently from 054be64 to 3111945 Compare September 27, 2024 00:48
@oskirby oskirby force-pushed the flatpak-crate-autoupdate branch from cddd9b9 to a35fbfa Compare September 27, 2024 01:38
@oskirby oskirby force-pushed the flatpak-crate-autoupdate branch from dde9c2c to 0d2025d Compare September 27, 2024 01:47
@oskirby oskirby force-pushed the flatpak-crate-autoupdate branch from 0d2025d to 34252d3 Compare September 27, 2024 01:53
@oskirby oskirby marked this pull request as ready for review September 27, 2024 01:54
@oskirby oskirby requested a review from mcleinman September 27, 2024 16:13
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@oskirby oskirby merged commit 43fd81b into main Sep 27, 2024
114 checks passed
@oskirby oskirby deleted the flatpak-crate-autoupdate branch September 27, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants