VPN-4684: Add privacy features help sheet #8878
Conversation
src/translations/strings.yaml
Outdated
| value: Privacy features | ||
| comment: Title label for the privacy features help sheet | ||
| privacyHeader: | ||
| value: What do privacy features do for me? |
There was a problem hiding this comment.
"What do…do" doesn't sound great?
"What can…do" looks like a minimal change here.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, I think this is a good suggestion, especially because "do" implies they do it by default, but "can" is more aligned with the fact that users can turn things off or on here.
Anyway, I agree, I think we should update to "What can privacy features do for me?"
Uh oh! Looks like an error! DetailsClient ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes: This request requires the client to satisfy the following scope expression:
|
| onClicked: helpSheetLoader.active = true | ||
|
|
||
| accessibleName: MZI18n.GlobalHelp | ||
| Accessible.ignored: !visible |
There was a problem hiding this comment.
MZButtonBase has Accessible.ignored: !visible this already. Same comment for related PRs.
| privacyBody1: | ||
| value: Privacy features give you greater control over the types of content you see, helping you stay safe online. | ||
| comment: Body label for the privacy features help sheet | ||
| privacyBody2: | ||
| value: If you activate these features, they’ll overwrite any custom DNS you’re using. These protections are not a substitute for taking other security precautions — for example, while blocking malware you should still avoid downloading attachments in strange emails. | ||
| comment: Body label for the privacy features help sheet |
There was a problem hiding this comment.
Nit: Do we need to break up the body into two strings? Is it more flexible for localization if a single string (and a single Text field in the UI) is used?
Feel free to ignore this comment.
There was a problem hiding this comment.
In this case, one string provides more flexibility for translation.
There was a problem hiding this comment.
To get the UI to match the mocks layout/spacing, we have to use two text components here
src/mozillavpn.cpp
Outdated
| @@ -1381,6 +1381,11 @@ void MozillaVPN::registerUrlOpenerLabels() { | |||
| uo->registerUrlLabel("upgradeToAnnualUrl", []() -> QString { | |||
| return Constants::upgradeToAnnualUrl(); | |||
| }); | |||
|
|
|||
| uo->registerUrlLabel("sumoPrivacy", []() -> QString { | |||
| return "https://support.mozilla.org/en-US/kb/" | |||
There was a problem hiding this comment.
Same comment here, let's remove "en-US" so that moz.org can determine and reroute to the correct locale.
| {type: MZHelpSheet.BlockType.LinkButton, text: MZI18n.GlobalLearnMore, margin: 16, action: () => { MZUrlOpener.openUrlLabel("sumoPrivacy") } }, | ||
| ] | ||
|
|
||
| onClosed: helpSheetLoader.active = false |
There was a problem hiding this comment.
Do we anticipate these help sheets existing outside of Loaders? Any reason to not create a separate component for the Loader/HelpSheet duo? Seems like we could save ourselves a bit of duping.
There was a problem hiding this comment.
agree. see here
Co-authored-by: Francesco Lodolo <[email protected]>
MattLichtenstein
force-pushed
the
VPN-4684
branch
from
1503e1b to
06c10ac
Compare
MattLichtenstein
requested review from
lesleyjanenorton,
flodolo and
vinocher
Description
NOTE: Depends on #8864: VPN-4687: Add DNS settings help sheet
Screen.Recording.2023-12-28.at.3.20.42.PM.mov
Reference
VPN-4684: Implement the 'Privacy features' in-product help sheet