VPN-4691: Add location selection help sheet #8873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -928,6 +928,19 @@ devices: | |||
| value: My devices | |||
| comment: Title for the menu bar when viewing the devices or device limit pages | |||
|
|
|||
| locationTitle: | |||
There was a problem hiding this comment.
@flodolo format is incorrect now, but will be resolved once #8864 is merged. These strings will fall under the helpSheets label
MattLichtenstein
force-pushed
the
VPN-4691
branch
2 times, most recently
from
1f32dbd to
b2a7740
Compare
flodolo
approved these changes
Dec 29, 2023
src/mozillavpn.cpp
Outdated
| @@ -1381,6 +1381,11 @@ void MozillaVPN::registerUrlOpenerLabels() { | |||
| uo->registerUrlLabel("upgradeToAnnualUrl", []() -> QString { | |||
| return Constants::upgradeToAnnualUrl(); | |||
| }); | |||
|
|
|||
| uo->registerUrlLabel("sumoMultihop", []() -> QString { | |||
| return "https://support.mozilla.org/en-US/kb/" | |||
There was a problem hiding this comment.
Let's drop the "en-US" here because it stipulates that the page is shown in English. Without it, moz.org will route the page based on the person's browser language prefs.
lesleyjanenorton
requested changes
Jan 12, 2024
| @@ -156,19 +156,6 @@ FocusScope { | |||
| right: parent.right | |||
| } | |||
|
|
|||
| MZCollapsibleCard { | |||
There was a problem hiding this comment.
🤩✨🧹👋
...This is a great way for ServerList.qml to start the new year.
| @@ -131,6 +150,27 @@ Item { | |||
| } | |||
| } | |||
|
|
|||
| Loader { | |||
There was a problem hiding this comment.
A 'HelpSheetLoader' component is starting to sound better and better.
There was a problem hiding this comment.
yea... or even just a loader as the base for all sheets. will do this for all in a fast follow
MattLichtenstein
force-pushed
the
VPN-4691
branch
from
ba52e18 to
01ff742
Compare
lesleyjanenorton
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: Depends on #8864: VPN-4687: Add DNS settings help sheet
Screen.Recording.2023-12-27.at.3.09.03.PM.mov
Reference
VPN-4691: Implement the 'Location Selection' in-product help sheet