Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication input error message visibility on Android #3804

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

lesleyjanenorton
Copy link
Member

Description

This fixes behavior described in #3729. 
Screen.Recording.2022-06-21.at.1.54.44.PM.mov

Reference

#3279

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@lesleyjanenorton lesleyjanenorton requested a review from flozia June 21, 2022 19:07
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #3804 (670a6ae) into main (a3ed8ff) will decrease coverage by 32.77%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #3804       +/-   ##
===========================================
- Coverage   60.95%   28.18%   -32.78%     
===========================================
  Files         283      279        -4     
  Lines       18397    16806     -1591     
  Branches     9118     9118               
===========================================
- Hits        11214     4736     -6478     
- Misses       5264     5985      +721     
- Partials     1919     6085     +4166     
Flag Coverage Δ
functional_tests 23.12% <ø> (-5.59%) ⬇️
lottie_tests 56.33% <ø> (ø)
qml_tests 10.67% <ø> (ø)
unit_tests 26.94% <ø> (-43.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/models/guide.h 0.00% <0.00%> (-100.00%) ⬇️
src/models/guidemodel.h 0.00% <0.00%> (-100.00%) ⬇️
src/connectionbenchmark/benchmarktask.h 0.00% <0.00%> (-100.00%) ⬇️
src/connectionbenchmark/benchmarktasksentinel.h 0.00% <0.00%> (-100.00%) ⬇️
tests/unit/testtutorial.cpp 5.42% <0.00%> (-94.58%) ⬇️
tests/unit/testguide.cpp 6.48% <0.00%> (-93.52%) ⬇️
tests/unit/testfeature.cpp 6.61% <0.00%> (-93.39%) ⬇️
tests/unit/testandroidmigration.cpp 7.31% <0.00%> (-92.69%) ⬇️
tests/unit/testserveri18n.cpp 7.69% <0.00%> (-92.31%) ⬇️
tests/unit/testmodels.cpp 7.81% <0.00%> (-91.79%) ⬇️
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ed8ff...670a6ae. Read the comment docs.

@lesleyjanenorton lesleyjanenorton merged commit 4511a39 into main Jun 22, 2022
@lesleyjanenorton lesleyjanenorton deleted the fix-iaa-android-errors-3279 branch June 22, 2022 14:06
@strseb strseb added this to the 2.9.0 milestone Jun 23, 2022
@strseb strseb added the 🚀 Uplifted This PR was Uplifted into a Release branch during CodeFreeze label Jun 23, 2022
strseb pushed a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Uplifted This PR was Uplifted into a Release branch during CodeFreeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants