Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an unblock-code-required issue - fix VPN-2037 #3279

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

bakulf
Copy link
Collaborator

@bakulf bakulf commented Apr 6, 2022

No description provided.

@bakulf bakulf requested a review from lesleyjanenorton April 6, 2022 15:28
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #3279 (e75c515) into main (a5eb0d8) will decrease coverage by 0.52%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3279      +/-   ##
==========================================
- Coverage   59.77%   59.25%   -0.53%     
==========================================
  Files         277      277              
  Lines       15961    15961              
  Branches     5284     5284              
==========================================
- Hits         9541     9457      -84     
- Misses       4976     5099     +123     
+ Partials     1444     1405      -39     
Flag Coverage Δ
functional_tests 25.15% <0.00%> (-0.73%) ⬇️
lottie_tests 56.82% <ø> (ø)
qml_tests 11.49% <ø> (ø)
unit_tests 73.44% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uthenticationinapp/authenticationinapplistener.cpp 67.66% <0.00%> (ø)
src/captiveportal/captiveportalnotifier.cpp 0.00% <0.00%> (-59.10%) ⬇️
src/captiveportal/captiveportaldetection.cpp 30.00% <0.00%> (-23.85%) ⬇️
...rc/features/featureserverunavailablenotification.h 61.53% <0.00%> (-15.39%) ⬇️
src/qmlengineholder.cpp 56.41% <0.00%> (-15.39%) ⬇️
src/features/featurenotificationcontrol.h 87.50% <0.00%> (-12.50%) ⬇️
src/tasks/group/taskgroup.cpp 66.66% <0.00%> (-6.07%) ⬇️
src/notificationhandler.cpp 31.40% <0.00%> (-4.96%) ⬇️
src/connectionhealth.cpp 56.15% <0.00%> (-3.08%) ⬇️
src/inspector/inspectorhandler.cpp 19.13% <0.00%> (-3.07%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5eb0d8...e75c515. Read the comment docs.

@bakulf bakulf merged commit f5a0d75 into main Apr 7, 2022
@bakulf bakulf deleted the unblockCode branch April 7, 2022 05:13
lesleyjanenorton added a commit that referenced this pull request Jun 21, 2022
strseb pushed a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants