Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix App Added Alert #2037

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Fix App Added Alert #2037

merged 3 commits into from
Oct 18, 2021

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Oct 14, 2021

  • We did not call show() thus it did not show.
  • After calling show() it is rendered below the Settings Header, so i moved it to be just below it :)

closes #1921

@strseb strseb requested a review from flozia October 14, 2021 16:10
Copy link
Collaborator

@flozia flozia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice — the fix works for me. My comments are only related to syntax and formatting. Since we have no JS style guide or linter for JS this is just personal preference.

Nit
I’m seeing some warnings that come from ViewAppPermissions.qml that would be nice to be resolved as part of this PR or a new issue.

  • L59: toast is not defined
  • L61: VPNCheckBoxAlert is managed by a layout and should not have anchors props

Comment on lines 77 to 82
if( component.status != Component.Ready )
{
if( component.status == Component.Error )
console.debug("Error:"+ component.errorString() );

}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case we need to keep this console.log this could be a single if block:

Suggested change
if( component.status != Component.Ready )
{
if( component.status == Component.Error )
console.debug("Error:"+ component.errorString() );
}
if (component.status != Component.Ready && component.status == Component.Error) {
console.debug("Error: " + component.errorString());
}

src/ui/components/VPNAlert.qml Outdated Show resolved Hide resolved
src/ui/settings/ViewAppPermissions.qml Outdated Show resolved Hide resolved
@strseb strseb merged commit be68bf0 into main Oct 18, 2021
@strseb strseb deleted the basti/fix_appAdded_alert branch October 26, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message not displayed when adding an application to the exclusion list from App Permissions menu
2 participants