-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix App Added Alert #2037
Fix App Added Alert #2037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice — the fix works for me. My comments are only related to syntax and formatting. Since we have no JS style guide or linter for JS this is just personal preference.
Nit
I’m seeing some warnings that come from ViewAppPermissions.qml
that would be nice to be resolved as part of this PR or a new issue.
- L59:
toast
is not defined - L61:
VPNCheckBoxAlert
is managed by a layout and should not haveanchors
props
if( component.status != Component.Ready ) | ||
{ | ||
if( component.status == Component.Error ) | ||
console.debug("Error:"+ component.errorString() ); | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case we need to keep this console.log
this could be a single if
block:
if( component.status != Component.Ready ) | |
{ | |
if( component.status == Component.Error ) | |
console.debug("Error:"+ component.errorString() ); | |
} | |
if (component.status != Component.Ready && component.status == Component.Error) { | |
console.debug("Error: " + component.errorString()); | |
} |
Co-authored-by: Florian Zia <[email protected]>
closes #1921