Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message not displayed when adding an application to the exclusion list from App Permissions menu #1921

Closed
data-sync-user opened this issue Sep 30, 2021 · 2 comments · Fixed by #2037
Assignees
Labels
bug Something isn't working

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Sep 30, 2021

Affected versions:

  • Mozilla VPN 2.5.1 (2.202109292239);

Affected Platforms:

  • Windows 10;

Prerequisites:

  • Have an FxA account (with an active subscription for Mozilla VPN);
  • Have Mozilla VPN app installed and in off state;
  • Be in Settings - Network Settings - App permissions menu;

Steps to reproduce:

  1. Scroll down to the bottom of the menu and click on the “+Add Application”;
  2. Select an application that is not on the exclusion list and add it to the list;
  3. Observe the screen.

Expected result:

  • “Success! You added the app to this list.” green banner is displayed at the top of the screen. The added application is checked by default and highlighted.

Actual result:

  • “Success! You added the app to this list.” green banner is not displayed at the top of the screen. The added application is not checked and is not highlighted.

Notes:

  • This issue was encountered before on Mozilla VPN 2.4.0 (issue: 778).

┆Issue is synchronized with this Jira Task

@data-sync-user
Copy link
Collaborator Author

➤ Luminita Buruian commented:

Verified the fix on windows 10, using Mozilla VPN v 2.6.0 (2.202110210311).

While the banner is now displayed, it looks a bit out of place. We should consider moving it right under the header or at the top of the screen. (please see image below)

!App permissions green banner.PNG|width=274,height=416!

CC: Valentina Virlics Madalin Cotetiu

@data-sync-user
Copy link
Collaborator Author

➤ Luminita Buruian commented:

I have retested this today on VPN version 2.7.0 (2.202111080356) and, although the banner is now displayed, the added application is neither checked by default, nor highlighted. Is that expected?

I have added a new issue for the incorrect placement of the banners here ( https://mozilla-hub.atlassian.net/browse/VPN-1291 ) .

Thank you.

CC: Valentina Virlics Madalin Cotetiu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants