VPN-6213 part 4: Remove unused colors #10019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulling out all unused colors. At one point I changed all
addTransparency(someColorName, 0.0)
tocolor.transparent
but that led to bugs. I left a comment to try to steer others away from this same trap.From my testing, there are no missing colors when using the app. The logs do have some statements like
QML MZInputBackground: The current style does not support customization of this control (property: "background" item: MZInputBackground_QMLTYPE_133(0x6000020bebc0, parent=0x0, geometry=0,0 0x0)). Please customize a non-native style (such as Basic, Fusion, Material, etc). For more information, see: https://doc.qt.io/qt-6/qtquickcontrols2-customize.html#customization-reference (MZSearchBar.qml:41)
, but this is unrelated to VPN-6213 - it exists onmain
as well.This builds on #10015, which in turn builds on #10014, which in turn builds on #9983. All 3 have been merged into main.
There will be one more color-related PR coming, built on top of this. It will better structure all of this for swapping in new themes.
Reference
VPN-6213
Checklist