-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPN-6213 part 2 - Pull colors into one file #10014
Conversation
@@ -60,7 +60,7 @@ Rectangle { | |||
|
|||
PropertyChanges { | |||
target: buttonBackground | |||
color: 'buttonDisabled' in colorScheme ? colorScheme.buttonDisabled : colorScheme.defaultColor | |||
color: colorScheme.buttonDisabled ? colorScheme.buttonDisabled : colorScheme.defaultColor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old way of checking produced warnings that it couldn't find buttonDisabled (and it would fall back on defaultColor
), this way silences the warnings. 🤯
Uh oh! Looks like an error!Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goodness, that's a lot of changes! Kind of overwhelming to review, but as far as I can tell it looks good.
Description
We had colors in two different files. We didn't have a good reason for this, so all colors have now been moved to one file. In the process, we removed some duplicate color hashes, fixed the identically named colors, and fixed some color-related log warnings. It may be easier to review this PR commit by commit.
#1CC5A0
green70
, which is #1CC4A0. This difference is imperceptible, and allows us to reuse a color.This PR builds on #9983, which has been merged to main.
Next few PRs for this ticket, to be built on top of one another:
Reference
VPN-6213
Checklist