Bugfix FXIOS-5304 [v109] Fixes pinned sites no longer work from add to shortcuts

[tarikeshaq]

Bugfix for #12461

Removes the extra query to the browser.db when adding a pinned site through the Add to Shortcuts button.

• In 107 we removed favicons from the SQL layer
• The query joins with the favicons table, which there is a really good chance doesn't have the site
• The query returns an empty site, then the actual add to pinned sites won't run

This PR removes that extra query and instead writes directly to the pinned sites. Note that since we no longer run the query, we now don't have the site's guid. but that's okay, it's nullable and pinned sites don't really need to have site's history guid.

I put this as 108 since it was a regression in 107. But please feel free to change it up to whatever the team sees fit!

[lmarceau]

v108 is now on hard freeze, so I'll put this in as v109

[lmarceau]

Build was green here

[nbhasin2]

Sync'd with @tarikeshaq and this does not support backwards compatibility so v109 change once happens will require additional work if we ever want to downgrade.

@tarikeshaq Do you think its worth to support backward compatibility?

[mergify]

This pull request has conflicts when rebasing. Could you fix it @tarikeshaq?

[mergify]

This pull request has conflicts when rebasing. Could you fix it @tarikeshaq?

[tarikeshaq]

@tarikeshaq Do you think its worth to support backward compatibility?

Because it's close to the 109 cut off, and removing backward compatibility meant crashing if we downgrade, I simplified the fix to only skip the joining with the favicon table - which is a safer approach, but we keep the extra query

cc @nbhasin2 does that make sense? if so we can probably land this so it hits 109

[nbhasin2]

This is much simpler @tarikeshaq r+

[lmarceau]

Build is green here