Uses display title for pinned sites

mozilla-mobile · Dec 8, 2022 · b34f29d · b34f29d
1 parent a192b4a
commit b34f29d
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/Client/Frontend/Browser/MainMenuActionHelper.swift b/Client/Frontend/Browser/MainMenuActionHelper.swift
@@ -734,7 +734,7 @@ class MainMenuActionHelper:
                                      iconString: ImageIdentifiers.addShortcut) { _ in
 
             guard let url = self.selectedTab?.url?.displayURL,
-                  let title = self.selectedTab?.title
+                  let title = self.selectedTab?.displayTitle
             else { return }
 
             self.profile.history.addPinnedTopSite(Site(url: url.absoluteString, title: title)).uponQueue(.main) { result in
@@ -750,15 +750,11 @@ class MainMenuActionHelper:
         return SingleActionViewModel(title: .AppMenu.RemoveFromShortcuts,
                                      iconString: ImageIdentifiers.removeFromShortcut) { _ in
 
-            guard let url = self.selectedTab?.url?.displayURL, let sql = self.profile.history as? SQLiteHistory else { return }
-
-            sql.getSites(forURLs: [url.absoluteString]).bind { val -> Success in
-                guard let site = val.successValue?.asArray().first?.flatMap({ $0 }) else {
-                    return succeed()
-                }
+            guard let url = self.selectedTab?.url?.displayURL,
+                  let title = self.selectedTab?.displayTitle
+            else { return }
 
-                return self.profile.history.removeFromPinnedTopSites(site)
-            }.uponQueue(.main) { result in
+            self.profile.history.removeFromPinnedTopSites(Site(url: url.absoluteString, title: title)).uponQueue(.main) { result in
                 if result.isSuccess {
                     self.delegate?.showToast(message: .AppMenu.RemovePinFromShortcutsConfirmMessage, toastAction: .removePinPage, url: nil)
                 }