Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use panda_arm description with hand arg #83

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

gautz
Copy link

@gautz gautz commented Aug 31, 2021

Problem:
roslaunch panda_moveit_config demo.launch
raises:

No such file or directory: /opt/ros/noetic/share/franka_description/robots/panda_arm_hand.urdf.xacro [Errno 2] No such file or directory: '/opt/ros/noetic/share/franka_description/robots/panda_arm_hand.urdf.xacro'
RLException: while processing /home/gah/tasks_ws/src/panda_moveit_config/launch/planning_context.launch:
Invalid <param> tag: Cannot load command parameter [robot_description]: command [['/opt/ros/noetic/lib/xacro/xacro', '/opt/ros/noetic/share/franka_description/robots/panda_arm_hand.urdf.xacro']] returned with code [2]. 

Param xml is <param if="$(eval arg('load_robot_description') and arg('load_gripper'))" name="$(arg robot_description)" command="$(find xacro)/xacro '$(find franka_description)/robots/panda_arm_hand.urdf.xacro'"/>
The traceback for the exception was written to the log file

Solution:
panda_arm_hand.urdf.xacro has been replaced by panda_arm.urdf.xacro hand:=$(arg load_gripper)
see: frankaemika/franka_ros@2dc8852

@rickstaa
Copy link
Contributor

rickstaa commented Sep 2, 2021

LGTM I had to solve the same problem when trying to get the noetic-devel version released #74 (comment).

@tammerb
Copy link

tammerb commented Sep 5, 2021

I PR'd an alternate solution to this same issue.

@rickstaa
Copy link
Contributor

rickstaa commented Sep 6, 2021

@tammerb Thanks for merging your pull request. One question, why did you split the robot_description loading code into two statements. In my opinion, a combination of your pull request gives the most concise solution:

<!-- Load universal robot description format (URDF) -->
<param if="$(arg load_robot_description)" name="$(arg robot_description)" command="xacro hand:=$(arg load_gripper) '$(find franka_description)/robots/panda_arm.urdf.xacro'"/>

Further, maybe the .setup_assistant should also be updated? Or do you want that file to represent the setup that was used when it was run?

@rhaschke rhaschke merged commit 78e783a into moveit:melodic-devel Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants