Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyMap implementation #9

Closed
wants to merge 4 commits into from
Closed

PropertyMap implementation #9

wants to merge 4 commits into from

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Dec 12, 2017

I implemented the PropertyMap we discussed a while ago.
Using this PropertyMap I also generalized the grasp frame specification for GenerateGraspPose - getting rid of hard-coded YPR angles. This allows for our PA10 example to be included easily.

replacing scalar graspOffset and hard-coded Euler angles with arbitrary graspFrame
@rhaschke rhaschke requested a review from v4hn December 12, 2017 16:33
@rhaschke rhaschke force-pushed the wip-properties branch 2 times, most recently from 2afadbf to 7b0bf2e Compare December 12, 2017 20:28
@rhaschke
Copy link
Contributor Author

I have some more additions to this. Closing for now, will reopen later.

@rhaschke rhaschke closed this Dec 13, 2017
@rhaschke
Copy link
Contributor Author

rhaschke commented Dec 13, 2017

@v4hn You could review this now. I merged already with master to fix the merge conflicts due to reordering of source files in cmake. I had to re-open as new PR #11.

sjahr added a commit to henningkayser/moveit_task_constructor that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant