PropertyMap implementation #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@v4hn Could you please have a look? |
replacing scalar graspOffset and hard-coded Euler angles with arbitrary graspFrame
Use different function names for different semantics.
rhaschke
force-pushed
the
wip-properties
branch
from
9b26002 to
0374af2
Compare
setValue() also updates the default value. reset() reset to the default value. setCurrentValue() only updates the current value, keeping current default. Thus setCurrentValue() can be reverted (to default) using reset().
First from INTERFACE, second from PARENT. INTERFACE initialization only makes sense for Propagating stages. Connecting stages should ensure that interfaces define identical properties which is not possible with boost::any.
throw std::logic_error on type errors throw std::runtime_error on undeclared property don't expose generic PropertyMap::declare()
rhaschke
force-pushed
the
wip-properties
branch
from
0374af2 to
e936391
Compare
Merged
... to allow for syncing with rviz::Property
rhaschke
force-pushed
the
wip-properties
branch
from
fa73acf to
fe2c4f3
Compare
|
ok, so this request has a number of small issues, but you already addressed and reworked some of them in the latter requests. It compiles (up to one vector include on my machine) and runs, so I will merge it to get on with the other requests. |
|
I should have fast-forwarded. This made the history even harder to read... sigh |
Oh no. Really? This will become a nightmare now. I have put so much effort to keep a clear history tree. |
sea-bass
added a commit
to sea-bass/moveit_task_constructor
that referenced
this pull request
Dec 8, 2022
sea-bass
added a commit
to sea-bass/moveit_task_constructor
that referenced
this pull request
Mar 10, 2023
sjahr
pushed a commit
to sjahr/moveit_task_constructor
that referenced
this pull request
May 3, 2023
sjahr
pushed a commit
to sjahr/moveit_task_constructor
that referenced
this pull request
May 30, 2023
mechwiz
pushed a commit
to mechwiz/moveit_task_constructor
that referenced
this pull request
May 30, 2023
…empty (moveit#11) (#5) Co-authored-by: Sebastian Castro <[email protected]>
mechwiz
pushed a commit
to mechwiz/moveit_task_constructor
that referenced
this pull request
Jul 19, 2023
mechwiz
pushed a commit
to mechwiz/moveit_task_constructor
that referenced
this pull request
Jul 21, 2023
mechwiz
pushed a commit
to mechwiz/moveit_task_constructor
that referenced
this pull request
Jul 24, 2023
mechwiz
pushed a commit
to mechwiz/moveit_task_constructor
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #9, implementing the
PropertyMapwe discussed a while ago.Using this
PropertyMapI also generalized the grasp frame specification forGenerateGraspPose- getting rid of hard-coded YPR angles. This allows for our PA10 example to be included easily.I merged already with master to fix conflicts due to reordering of source files in cmake.