-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Improve: panda_moveit: Add parameters for perception tutorial #181
base: ros2
Are you sure you want to change the base?
Conversation
5badec1
to
f949062
Compare
(Dev-testing) Reading params from a file seems to be failing.
UPDATE: Param file format was wrong, had to be ros2-ified. |
f949062
to
8a082a9
Compare
8a082a9
to
646722b
Compare
<xacro:arg name="use_fake_hardware" default="false"/> | ||
<xacro:arg name="fake_sensor_commands" default="false"/> | ||
|
||
<xacro:include filename="$(find franka_description)/robots/panda_arm.xacro"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This single file is obviously not enough as some lines depend on franka_description
pkg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did they switch moveit_tutorials from panda_moveit_config
to moveit_resources_panda_moveit_config
in ROS2?
I suggest adapting panda_moveit_config for ROS2 (it already has a rolling-devel
branch) instead of switching to and bloating moveit_resources.
@rhaschke I'm not entirely sure, I haven't seen the rationale to switch to My guess is that |
…_param_builder' pkg
…t_config/demo.launch.py
…be reverted) Signed-off-by: Isaac Saito <[email protected]>
Issue
In the tutorial at the time of writing, those params are meant to be added manually by a reader. While that is not very nice, the tutorial does not instruct to build necessary pkgs from source, so readers would have little to no idea for what to do.
Approach toward solution
franka_description
.Related work