-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port simplified benchmarking tutorial #772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
reviewed
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good! Didn't find anything major.
Comment on lines
1
to
4
:moveit1: | ||
|
||
.. | ||
Once updated for MoveIt 2, remove all lines above title (including this comment and :moveit1: tag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to remove this, right?
Co-authored-by: Sebastian Castro <[email protected]>
sjahr
force-pushed
the
pr-add_simple_benchmarking_tutorial
branch
from
September 25, 2023 16:19
cdb6d6d
to
00346c7
Compare
sea-bass
approved these changes
Sep 26, 2023
disvorten
added a commit
to Natashe4ka/moveit2_tutorials
that referenced
this pull request
Oct 12, 2023
This reverts commit 4377c59.
sjahr
added a commit
to sjahr/moveit2_tutorials
that referenced
this pull request
Oct 26, 2023
* Add benchmarking tutorial * Update tutorial text * Apply suggestions from code review Co-authored-by: Sebastian Castro <[email protected]> * Address review * Fix link --------- Co-authored-by: Sebastian Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port and simplify benchmarking tutorial
Checklist