Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port simplified benchmarking tutorial #772

Merged
merged 6 commits into from
Sep 27, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Sep 25, 2023

Description

Port and simplify benchmarking tutorial

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! Didn't find anything major.

Comment on lines 1 to 4
:moveit1:

..
Once updated for MoveIt 2, remove all lines above title (including this comment and :moveit1: tag)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to remove this, right?

doc/how_to_guides/benchmarking/benchmarking_tutorial.rst Outdated Show resolved Hide resolved
doc/how_to_guides/benchmarking/benchmarking_tutorial.rst Outdated Show resolved Hide resolved
@sjahr sjahr force-pushed the pr-add_simple_benchmarking_tutorial branch from cdb6d6d to 00346c7 Compare September 25, 2023 16:19
@sjahr sjahr self-assigned this Sep 26, 2023
@sjahr sjahr requested a review from sea-bass September 26, 2023 12:22
@sjahr sjahr merged commit 4377c59 into moveit:main Sep 27, 2023
9 checks passed
disvorten added a commit to Natashe4ka/moveit2_tutorials that referenced this pull request Oct 12, 2023
sjahr added a commit to sjahr/moveit2_tutorials that referenced this pull request Oct 26, 2023
* Add benchmarking tutorial

* Update tutorial text

* Apply suggestions from code review

Co-authored-by: Sebastian Castro <[email protected]>

* Address review

* Fix link

---------

Co-authored-by: Sebastian Castro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants