Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not perform most Jazzy CI jobs on main branch #3142

Merged
merged 3 commits into from
Nov 30, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Nov 29, 2024

Description

This is a complementary PR to #3141.

Jazzy Docker and tutorial images will now be built off the jazzy branch.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass changed the title Do not build Jazzy tutorial image on main branch Do not perform most Jazzy CI jobs on main branch Nov 29, 2024
@sea-bass
Copy link
Contributor Author

Rolling failures expected until #3139 is merged btw

@sea-bass sea-bass mentioned this pull request Nov 29, 2024
6 tasks
@sea-bass sea-bass requested a review from sjahr November 29, 2024 16:43
@sea-bass sea-bass enabled auto-merge November 29, 2024 23:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.62%. Comparing base (b781196) to head (21a0dbc).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3142      +/-   ##
==========================================
- Coverage   46.00%   45.62%   -0.38%     
==========================================
  Files         483      482       -1     
  Lines       40632    40432     -200     
==========================================
- Hits        18689    18443     -246     
- Misses      21943    21989      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit e7872eb Nov 30, 2024
13 of 14 checks passed
@sea-bass sea-bass deleted the no-tutorial-jazzy-on-main branch November 30, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants